WRN-6761: VirtualGridListNative keeps scrolling after rotated while scrolling in Android #2987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2987 +/- ##
===========================================
- Coverage 47.44% 47.39% -0.06%
===========================================
Files 171 171
Lines 9475 9485 +10
Branches 2364 2368 +4
===========================================
Hits 4495 4495
- Misses 3866 3872 +6
- Partials 1114 1118 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Changed the structure of the handleResizeWinodw from both Scrollable Native and useScroll so that the problem is less visible.
This problem was reproduced on all the components that used Scrollable Native and useScroll across all the libraries. This solution does not cover the Safari browser for IOS because of a strange interaction between overflow hidden and it (the items remain invisible until the user manually scrolls a bit).
Resolution
Additional Considerations
The solution is not a perfect fix as in some rare cases the list is not 100% at the top(the worst I've seen it was a little bit past it but the first element was still visible) but it should stop the scrolling effect from after the screen was rotated.
Links
WRN-6761
Comments