Remove unnecessary eval() in wrapSyscallFunction#26609
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Apr 3, 2026
Merged
Remove unnecessary eval() in wrapSyscallFunction#26609sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
There is no need to turn the string back into a JS function here.
kripken
reviewed
Apr 2, 2026
|
|
||
| for (var x in SyscallsLibrary) { | ||
| wrapSyscallFunction(x, SyscallsLibrary, false); | ||
| for (const name of Object.keys(SyscallsLibrary)) { |
Collaborator
Author
There was a problem hiding this comment.
for .. of is pretty much always preferred over for .. in in modern JS.
The in interator has the problem that it iterates over everything, no just "own properties", so technically usage of in should using be paired with hasOwnProperty
Member
There was a problem hiding this comment.
Fair enough, but here you also add Object.keys(). I guess maybe the overhead is not a big deal in this case, but the code ends up longer and less clear in my opinion?
Collaborator
Author
There was a problem hiding this comment.
I just think we should follow best modern JS practices everwhere in the compiler.
We can do crazy stuff in the generated code I guess, but no reason to micro-optimize the compiler code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to turn the string back into a JS function here.