Adds support of multipart/related for inline attachments #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multipart/related to the mail package by introducing a new
RelatedWriterand corresponding methods to the package. See #179 for more information about the usecases.This PR also renames existing functions and methods to make the wording more uniform. In detail, the following renamings have been added:
InlineWritertoAlternativeWriterto represent its task of writing "multipart/alternative", the same way like the newRelatedWriterwrites "multipart/related".CreateInlineWriter()toCreateAlternativeWriter()to match the renaming of the returned writer.Writer.CreateInline()toWriter.CreateAlternative()to match the renaming of the returned writer.The old namings are still in-place and marked as deprecated, so this PR does not introduce a BC break.