-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[Next] Kill Evented #20917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[Next] Kill Evented #20917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Development AssetsDiff --- main/out.txt 2025-06-10 16:53:24.000000000 +0000
+++ pr/./pr-15569481631/out.txt 2025-06-10 20:24:28.000000000 +0000
@@ -1,11 +1,11 @@
2.2M └─┬ .
-1014K ├─┬ @ember
+1011K ├─┬ @ember
205K │ ├─┬ -internals
- 69K │ │ ├─┬ views
- 64K │ │ │ └─┬ lib
+ 68K │ │ ├─┬ views
+ 63K │ │ │ └─┬ lib
23K │ │ │ ├── mixins
22K │ │ │ ├── system
- 10K │ │ │ ├── views
+ 9.6K │ │ │ ├── views
4.3K │ │ │ └── compat
35K │ │ ├─┬ runtime
30K │ │ │ └─┬ lib
@@ -15,7 +15,7 @@
21K │ │ │ └── lib
11K │ │ ├── owner
9.4K │ │ ├── deprecations
- 7.4K │ │ ├── metal
+ 7.3K │ │ ├── metal
7.0K │ │ ├── string
5.0K │ │ ├── glimmer
4.9K │ │ ├── utils
@@ -25,9 +25,9 @@
4.2K │ │ ├── container
4.2K │ │ ├── browser-environment
4.1K │ │ └── environment
- 183K │ ├─┬ routing
+ 182K │ ├─┬ routing
28K │ │ └── lib
- 149K │ ├─┬ object
+ 148K │ ├─┬ object
66K │ │ └─┬ lib
62K │ │ └── computed
114K │ ├─┬ template-compiler
@@ -43,7 +43,7 @@
4.9K │ │ └── lib
31K │ ├─┬ engine
4.7K │ │ └── lib
- 27K │ ├── runloop
+ 26K │ ├── runloop
22K │ ├─┬ utils
18K │ │ └── lib
20K │ ├── helper
@@ -63,7 +63,7 @@
4.2K │ ├── deprecated-features
4.1K │ ├── template-factory
4.1K │ └── version
- 708K ├── shared-chunks
+ 706K ├── shared-chunks
384K ├─┬ @glimmer
166K │ ├── runtime
60K │ ├── opcode-compiler Details
|
9a217b7
to
2182a39
Compare
wagenet
commented
Jun 9, 2025
packages/@ember/-internals/glimmer/tests/integration/event-dispatcher-test.js
Outdated
Show resolved
Hide resolved
wagenet
commented
Jun 9, 2025
packages/@ember/-internals/glimmer/tests/integration/syntax/each-test.js
Outdated
Show resolved
Hide resolved
wagenet
commented
Jun 9, 2025
5207a67
to
76eeb43
Compare
wagenet
commented
Jun 10, 2025
@@ -1488,6 +1447,7 @@ class Route<Model = unknown> extends EmberObject.extend(ActionHandler, Evented) | |||
} | |||
} | |||
|
|||
// TODO: Revisit the docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll want to update these eventually.
NullVoxPopuli
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this to land in main we will need to have first deprecated
@ember/object/evented
and all of its methods.In its current implementation, this PR continues to support event handlers for the Router, but not Routes themselves.