Skip to content

[Next] Kill Evented #20917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged

[Next] Kill Evented #20917

merged 1 commit into from
Jun 10, 2025

Conversation

wagenet
Copy link
Member

@wagenet wagenet commented Jun 9, 2025

For this to land in main we will need to have first deprecated @ember/object/evented and all of its methods.

In its current implementation, this PR continues to support event handlers for the Router, but not Routes themselves.

Copy link

github-actions bot commented Jun 9, 2025

Development Assets

Diff

--- main/out.txt	2025-06-10 16:53:24.000000000 +0000
+++ pr/./pr-15569481631/out.txt	2025-06-10 20:24:28.000000000 +0000
@@ -1,11 +1,11 @@
  2.2M └─┬ .
-1014K   ├─┬ @ember
+1011K   ├─┬ @ember
  205K   │ ├─┬ -internals
-  69K   │ │ ├─┬ views
-  64K   │ │ │ └─┬ lib
+  68K   │ │ ├─┬ views
+  63K   │ │ │ └─┬ lib
   23K   │ │ │   ├── mixins
   22K   │ │ │   ├── system
-  10K   │ │ │   ├── views
+ 9.6K   │ │ │   ├── views
  4.3K   │ │ │   └── compat
   35K   │ │ ├─┬ runtime
   30K   │ │ │ └─┬ lib
@@ -15,7 +15,7 @@
   21K   │ │ │ └── lib
   11K   │ │ ├── owner
  9.4K   │ │ ├── deprecations
- 7.4K   │ │ ├── metal
+ 7.3K   │ │ ├── metal
  7.0K   │ │ ├── string
  5.0K   │ │ ├── glimmer
  4.9K   │ │ ├── utils
@@ -25,9 +25,9 @@
  4.2K   │ │ ├── container
  4.2K   │ │ ├── browser-environment
  4.1K   │ │ └── environment
- 183K   │ ├─┬ routing
+ 182K   │ ├─┬ routing
   28K   │ │ └── lib
- 149K   │ ├─┬ object
+ 148K   │ ├─┬ object
   66K   │ │ └─┬ lib
   62K   │ │   └── computed
  114K   │ ├─┬ template-compiler
@@ -43,7 +43,7 @@
  4.9K   │ │ └── lib
   31K   │ ├─┬ engine
  4.7K   │ │ └── lib
-  27K   │ ├── runloop
+  26K   │ ├── runloop
   22K   │ ├─┬ utils
   18K   │ │ └── lib
   20K   │ ├── helper
@@ -63,7 +63,7 @@
  4.2K   │ ├── deprecated-features
  4.1K   │ ├── template-factory
  4.1K   │ └── version
- 708K   ├── shared-chunks
+ 706K   ├── shared-chunks
  384K   ├─┬ @glimmer
  166K   │ ├── runtime
   60K   │ ├── opcode-compiler

Details

This PRmain
Dev
 2.2M └─┬ .
1011K   ├─┬ @ember
 205K   │ ├─┬ -internals
  68K   │ │ ├─┬ views
  63K   │ │ │ └─┬ lib
  23K   │ │ │   ├── mixins
  22K   │ │ │   ├── system
 9.6K   │ │ │   ├── views
 4.3K   │ │ │   └── compat
  35K   │ │ ├─┬ runtime
  30K   │ │ │ └─┬ lib
  21K   │ │ │   ├── mixins
 5.7K   │ │ │   └── ext
  26K   │ │ ├─┬ meta
  21K   │ │ │ └── lib
  11K   │ │ ├── owner
 9.4K   │ │ ├── deprecations
 7.3K   │ │ ├── metal
 7.0K   │ │ ├── string
 5.0K   │ │ ├── glimmer
 4.9K   │ │ ├── utils
 4.9K   │ │ ├── routing
 4.5K   │ │ ├── error-handling
 4.5K   │ │ ├── utility-types
 4.2K   │ │ ├── container
 4.2K   │ │ ├── browser-environment
 4.1K   │ │ └── environment
 182K   │ ├─┬ routing
  28K   │ │ └── lib
 148K   │ ├─┬ object
  66K   │ │ └─┬ lib
  62K   │ │   └── computed
 114K   │ ├─┬ template-compiler
 109K   │ │ └─┬ lib
  20K   │ │   ├── plugins
 4.6K   │ │   ├── system
 4.1K   │ │   └── -internal
  66K   │ ├─┬ application
 5.6K   │ │ └── lib
  52K   │ ├─┬ debug
  21K   │ │ └── lib
  38K   │ ├─┬ array
 4.9K   │ │ └── lib
  31K   │ ├─┬ engine
 4.7K   │ │ └── lib
  26K   │ ├── runloop
  22K   │ ├─┬ utils
  18K   │ │ └── lib
  20K   │ ├── helper
  11K   │ ├── destroyable
 9.8K   │ ├── instrumentation
 9.4K   │ ├── controller
 7.4K   │ ├── service
 7.2K   │ ├── owner
 6.2K   │ ├── component
 5.6K   │ ├── canary-features
 5.5K   │ ├── modifier
 5.1K   │ ├── template-compilation
 5.0K   │ ├── enumerable
 5.0K   │ ├── test
 4.4K   │ ├── template
 4.4K   │ ├── renderer
 4.2K   │ ├── deprecated-features
 4.1K   │ ├── template-factory
 4.1K   │ └── version
 706K   ├── shared-chunks
 384K   ├─┬ @glimmer
 166K   │ ├── runtime
  60K   │ ├── opcode-compiler
  30K   │ ├── manager
  22K   │ ├── validator
  14K   │ ├── program
  12K   │ ├── reference
  11K   │ ├── destroyable
  10K   │ ├─┬ tracking
 4.4K   │ │ └── primitives
  10K   │ ├── util
 8.1K   │ ├── node
 7.3K   │ ├── global-context
 6.4K   │ ├── wire-format
 5.0K   │ ├── vm
 4.9K   │ ├── encoder
 4.6K   │ ├── owner
 4.1K   │ └── env
  60K   ├─┬ ember-testing
  56K   │ └─┬ lib
  14K   │   ├── test
  14K   │   ├── helpers
  10K   │   ├── ext
 6.4K   │   └── adapters
  31K   ├── backburner.js
  25K   ├── ember
  24K   ├── route-recognizer
  18K   ├─┬ @simple-dom
  14K   │ └── document
 9.2K   ├── dag-map
 4.3K   ├── rsvp
 4.3K   └── router_js
 2.2M └─┬ .
1014K   ├─┬ @ember
 205K   │ ├─┬ -internals
  69K   │ │ ├─┬ views
  64K   │ │ │ └─┬ lib
  23K   │ │ │   ├── mixins
  22K   │ │ │   ├── system
  10K   │ │ │   ├── views
 4.3K   │ │ │   └── compat
  35K   │ │ ├─┬ runtime
  30K   │ │ │ └─┬ lib
  21K   │ │ │   ├── mixins
 5.7K   │ │ │   └── ext
  26K   │ │ ├─┬ meta
  21K   │ │ │ └── lib
  11K   │ │ ├── owner
 9.4K   │ │ ├── deprecations
 7.4K   │ │ ├── metal
 7.0K   │ │ ├── string
 5.0K   │ │ ├── glimmer
 4.9K   │ │ ├── utils
 4.9K   │ │ ├── routing
 4.5K   │ │ ├── error-handling
 4.5K   │ │ ├── utility-types
 4.2K   │ │ ├── container
 4.2K   │ │ ├── browser-environment
 4.1K   │ │ └── environment
 183K   │ ├─┬ routing
  28K   │ │ └── lib
 149K   │ ├─┬ object
  66K   │ │ └─┬ lib
  62K   │ │   └── computed
 114K   │ ├─┬ template-compiler
 109K   │ │ └─┬ lib
  20K   │ │   ├── plugins
 4.6K   │ │   ├── system
 4.1K   │ │   └── -internal
  66K   │ ├─┬ application
 5.6K   │ │ └── lib
  52K   │ ├─┬ debug
  21K   │ │ └── lib
  38K   │ ├─┬ array
 4.9K   │ │ └── lib
  31K   │ ├─┬ engine
 4.7K   │ │ └── lib
  27K   │ ├── runloop
  22K   │ ├─┬ utils
  18K   │ │ └── lib
  20K   │ ├── helper
  11K   │ ├── destroyable
 9.8K   │ ├── instrumentation
 9.4K   │ ├── controller
 7.4K   │ ├── service
 7.2K   │ ├── owner
 6.2K   │ ├── component
 5.6K   │ ├── canary-features
 5.5K   │ ├── modifier
 5.1K   │ ├── template-compilation
 5.0K   │ ├── enumerable
 5.0K   │ ├── test
 4.4K   │ ├── template
 4.4K   │ ├── renderer
 4.2K   │ ├── deprecated-features
 4.1K   │ ├── template-factory
 4.1K   │ └── version
 708K   ├── shared-chunks
 384K   ├─┬ @glimmer
 166K   │ ├── runtime
  60K   │ ├── opcode-compiler
  30K   │ ├── manager
  22K   │ ├── validator
  14K   │ ├── program
  12K   │ ├── reference
  11K   │ ├── destroyable
  10K   │ ├─┬ tracking
 4.4K   │ │ └── primitives
  10K   │ ├── util
 8.1K   │ ├── node
 7.3K   │ ├── global-context
 6.4K   │ ├── wire-format
 5.0K   │ ├── vm
 4.9K   │ ├── encoder
 4.6K   │ ├── owner
 4.1K   │ └── env
  60K   ├─┬ ember-testing
  56K   │ └─┬ lib
  14K   │   ├── test
  14K   │   ├── helpers
  10K   │   ├── ext
 6.4K   │   └── adapters
  31K   ├── backburner.js
  25K   ├── ember
  24K   ├── route-recognizer
  18K   ├─┬ @simple-dom
  14K   │ └── document
 9.2K   ├── dag-map
 4.3K   ├── rsvp
 4.3K   └── router_js

@wagenet wagenet force-pushed the kill-evented branch 2 times, most recently from 9a217b7 to 2182a39 Compare June 9, 2025 22:10
@wagenet wagenet changed the title WIP: Kill Evented POC: Kill Evented Jun 9, 2025
@wagenet wagenet changed the base branch from main to next June 10, 2025 20:07
@wagenet wagenet changed the title POC: Kill Evented [Next] Kill Evented Jun 10, 2025
@wagenet wagenet force-pushed the kill-evented branch 2 times, most recently from 5207a67 to 76eeb43 Compare June 10, 2025 20:10
@wagenet wagenet marked this pull request as ready for review June 10, 2025 20:10
@@ -1488,6 +1447,7 @@ class Route<Model = unknown> extends EmberObject.extend(ActionHandler, Evented)
}
}

// TODO: Revisit the docs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to update these eventually.

@wagenet wagenet merged commit 9d26e9e into emberjs:next Jun 10, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants