Skip to content

Footer: separate data from the component #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

ppcano
Copy link
Contributor

@ppcano ppcano commented Sep 16, 2018

Implements #56

The component has been extended to support a few cases.

    {{es-footer }}
    {{es-footer tagline="A framework for ambitious web developers"}}
    {{#es-footer as |f|}}
      {{f.info infoLinks=infoLinks}}
      {{f.statement socialLinks=socialLinks}}
      {{f.contributions contributorLinks=contributorLinks}}
    {{/es-footer}}
    {{#es-footer as |f|}}
      {{#f.info}}
        <br/>
        <a>Team</a>
        <br/>
        <a>Contact</a>
      {{/f.info}}
      {{#f.statement}}
        Highly Productive Out of the Box
      {{/f.statement}}
      {{#f.contributions}}
        <div class="contributor">
          <p>Hosted by:</p>
          <a href="https://www.heroku.com/emberjs">
            {{svg-jar "heroku-logo" class="contributor-logo"}}
          </a>
        </div>
      {{/f.contributions}}
    {{/es-footer}}

The addon documentation has been included. I wait for feedback to modify the API and/or improve the documentation.

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a significant improvement from before so I think we should merge it now any improvements we have can be added iteratively 👍

@mansona mansona merged commit c65bc90 into ember-learn:master Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants