Breaking: drop support for Node 10, update ember to 3.28, and remove deprecations #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
force-pushed
the
upgrade
branch
3 times, most recently
from
648739c to
1145212
Compare
jaredgalanis
approved these changes
Dec 29, 2021
locks
approved these changes
Dec 30, 2021
Yes these failures are ok for now. We need some work to get embroider optimized working and the release-no-deprecations could be fixed now but it's not urgent. We can fix that after merging this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rather large PR to bring things in line to get ember website stuff ready for Ember 4.0 (and also fix some bugs introduced late in the 3.x series).
I know it's a lot of code but the work is done commit-by-commit so if you wanted to review this work you can review it commit-by-commit. Alternatively, we can easily split the work into at least 7 (maybe 8) individual PRs if we think that would be preferable 👍 let me know