fix htmlSafe import #402
Merged
fix htmlSafe import #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this locally and this does in fact fix the issue I was having with https://github.com/ember-learn/guidemaker-ember-template/pull/84/checks?check_run_id=3150847446#step:6:122 🎉 |
|
@mansona not sure about the test failure, do you know? |
|
So... It looks like it's only ember-canary that's falling so I'm not currently worried. It's likely something in a deprecation that has been removed so we probably need to go through and remove all deprecations soon 🙈 |
|
sgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing the htmlSafe import as described here https://deprecations.emberjs.com/v3.x#toc_ember-string-htmlsafe-ishtmlsafe
I think this is also causing issues in Ember 3.27 because of module issues 🤔