Skip to content

Upgrade v2 tracking branch to Ember 3.13 #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 6, 2021
Merged

Conversation

mansona
Copy link
Member

@mansona mansona commented Apr 29, 2021

This PR is to upgrade the v2 tracking branch's Ember version to 3.13 to allow for ember-learn/guidemaker-ember-template#78 to pass CI

As you can see, this PR does not target master. This is targeting a v2.x tracking branch that starts from the latest version of the v2.x series: v2.5.0.

This PR has been a tough one to get right because it's essentially full-on time travel coding 🙃 I had to upgrade and migrate a few things to be closer to what master does to even get this to work. If it passes tests I wouldn't worry too much because it will be tested properly downstream 👍

One problem with this change is that I had to drop Ember 3.4 and 3.8 from the test matrix because a dependency moved to co-location which needs a certain minimum version of Ember to work. This technically makes this a breaking change but we can't do that because v3 is already taken 🙈

We have a few options when it comes to dealing with this technical breaking change:

  • do nothing because we're pretty sure we know all the apps using v2.x of the ember-styleguide have been upgraded past 3.8
  • not release this to npm so that people with ^ dependencies won't have a broken experience because they won't get a broken upgrade automatically
  • release it to npm as a pre-minor version, which has the benefit of working fine with npm but it would need an explicit opt-in from anyone using it as a dependency (i.e. will avoid the automatic upgrade problem)

Once we agree on how we want to proceed with the release we can get this merged and I can release it in the agreed manor 👍

@mansona mansona force-pushed the upgrade-ember-3.13 branch 2 times, most recently from 4b5511a to 1025907 Compare April 29, 2021 15:22
@mansona mansona force-pushed the upgrade-ember-3.13 branch from b5bc6ee to 4f8c6c5 Compare May 1, 2021 13:47
@mansona mansona force-pushed the upgrade-ember-3.13 branch from 4f8c6c5 to 440e6cd Compare May 1, 2021 13:50
@mansona mansona changed the title Upgrade to Ember 3.13 Upgrade v2 tracking branch to Ember 3.13 May 1, 2021
@mansona mansona requested a review from jenweber May 1, 2021 14:06
Copy link
Contributor

@jenweber jenweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mansona
Copy link
Member Author

mansona commented May 6, 2021

We discussed this in Discord and we have agreed to got with option 3 for the release of this one:

release it to npm as a pre-minor version, which has the benefit of working fine with npm but it would need an explicit opt-in from anyone using it as a dependency (i.e. will avoid the automatic upgrade problem)

I will release this after it is merged 👍

@mansona mansona merged commit bd72fd9 into v2.x May 6, 2021
@mansona mansona deleted the upgrade-ember-3.13 branch May 6, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants