Upgrade v2 tracking branch to Ember 3.13 #393
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to upgrade the v2 tracking branch's Ember version to 3.13 to allow for ember-learn/guidemaker-ember-template#78 to pass CI
As you can see, this PR does not target master. This is targeting a v2.x tracking branch that starts from the latest version of the v2.x series: v2.5.0.
This PR has been a tough one to get right because it's essentially full-on time travel coding 🙃 I had to upgrade and migrate a few things to be closer to what
master
does to even get this to work. If it passes tests I wouldn't worry too much because it will be tested properly downstream 👍One problem with this change is that I had to drop Ember 3.4 and 3.8 from the test matrix because a dependency moved to co-location which needs a certain minimum version of Ember to work. This technically makes this a breaking change but we can't do that because v3 is already taken 🙈
We have a few options when it comes to dealing with this technical breaking change:
^
dependencies won't have a broken experience because they won't get a broken upgrade automaticallyOnce we agree on how we want to proceed with the release we can get this merged and I can release it in the agreed manor 👍