Skip to content

Move component template files to be co-located #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2021
Merged

Move component template files to be co-located #391

merged 1 commit into from
Apr 20, 2021

Conversation

hannakim91
Copy link
Contributor

@hannakim91 hannakim91 commented Apr 16, 2021 •
edited
Loading

@jaredgalanis jaredgalanis self-requested a review April 16, 2021 20:39
@hannakim91 hannakim91 marked this pull request as draft April 16, 2021 20:40
@hannakim91 hannakim91 force-pushed the co-located-components branch from 2467eaf to df8009f Compare April 20, 2021 21:08
@hannakim91 hannakim91 marked this pull request as ready for review April 20, 2021 21:11
jaredgalanis
jaredgalanis approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@jaredgalanis jaredgalanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉 Thank you so much for your contribution.

@jaredgalanis jaredgalanis merged commit c0f28d2 into ember-learn:master Apr 20, 2021
@jaredgalanis jaredgalanis mentioned this pull request Apr 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredgalanis jaredgalanis jaredgalanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

convert ember-styleguide to use co-located components
2 participants
@hannakim91 @jaredgalanis