Skip to content

Add styling for <hr/> #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 27, 2020
Merged

Add styling for <hr/> #334

merged 3 commits into from
Aug 27, 2020

Conversation

Mikek2252
Copy link
Contributor

@Mikek2252 Mikek2252 commented Aug 11, 2020 •
edited by mansona
Loading

Added the styling specified in the design in #329

Fixes #329

mansona
mansona requested changes Aug 13, 2020
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 🎉 can you please add this to the docs somewhere? you should be able to just add it to one of the Markdown files in the docs/ folder. Let me know if you have any questions 👍

mansona
mansona approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

I squashed a few commits just to make history a tiny bit cleaner 😉

@mansona mansona changed the title ISSUE: 329: Add styling for <hr/> Add styling for <hr/> Aug 27, 2020
@mansona mansona merged commit 45e8481 into ember-learn:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add styling for <hr/>
2 participants
@Mikek2252 @mansona