Set isDevelopingAddon to false #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.js
Outdated
| @@ -7,7 +7,7 @@ const nodeSass = require('node-sass'); | |||
| module.exports = { | |||
| name: require('./package').name, | |||
| isDevelopingAddon() { | |||
| return true; | |||
| return false; | |||
There was a problem hiding this comment.
since this is the default may be either delete this method or block comment it?
There was a problem hiding this comment.
yeah I can do that
toddjordan
force-pushed
the
set-isdeveloping-back-false
branch
from
b407a0d to
69208f8
Compare
|
Will want to publish once merged because this is causing implementers to get template lint errors |
sivakumar-kailasam
approved these changes
Oct 26, 2018
|
@toddjordan released a new version. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publishing the addon with isDevelopingAddon to true causes undesirable things such as an app's linting evaluating styleguide addon files (which is happening with ember-api-docs right now).