Skip to content

upgrading ember cli #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 15, 2018
Merged

upgrading ember cli #105

merged 3 commits into from
Oct 15, 2018

Conversation

aklkv
Copy link
Contributor

@aklkv aklkv commented Oct 14, 2018 •
edited
Loading

@MelSumner This pr upgrades ember-cli and several other packages.
Once this is merged I will submit subsequent PRs undressing the following:

  • I had turn off template linting, I will have template linting fixed in the next PR
  • new testing API has been around for awhile and I think we should utilize it. I have already done migration and I will submit PR once this one is merged.

@aklkv aklkv mentioned this pull request Oct 14, 2018
Closed
mansona
mansona approved these changes Oct 14, 2018
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a relatively straightforward upgrade of the ember-cli and some of the dependencies 👍 I don't think this will have any impact on any consuming apps so once it is merged I don't think we would need to release a major version

@aklkv
Copy link
Contributor Author

aklkv commented Oct 14, 2018 •
edited
Loading

@mansona @MelSumner One thing I had to update is ember-addon-docs to work with new ember-cli version. Due to changed in ember-add-docs API, landing page style and logo in main nav have been slitty changed. Please checkout deployed example.

@MelSumner MelSumner merged commit 34ea41f into ember-learn:master Oct 15, 2018
@aklkv aklkv deleted the feature/update branch October 15, 2018 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aklkv @mansona @MelSumner