General fixes - remove excess padding, remove display flex, fixing logo #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
changed the title
|
It looks like the changes I have made to the location of the logo haven't actually worked 🤔 https://percy.io/Ember/guides-app/builds/1065954?utm_campaign=Ember&utm_content=guides-app&utm_source=github_status I have a feeling there is a different behavior depending on if you are running this linked vs installed from elsewhere 🤔 is there any particular reason why we're using SVGJar? Does anyone object to us removing it? |
mansona
force-pushed
the
feature/remove-section-padding
branch
from
f2907ef to
a09ce44
Compare
mansona
force-pushed
the
feature/remove-section-padding
branch
from
cc01d3c to
75f5107
Compare
MelSumner
approved these changes
Oct 18, 2018
|
thanks @MelSumner 🎉 I'll add a label to issues like this in future 😖 my bad! 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have checked this locally and it does fix the issue with ember-learn/guides-app#252 👍
This has a bunch of changes that will allow the Percy build to pass for Guides App:
display: flexfrom section styles (allow apps to define that themselves)