Skip to content

Fix #22 #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 16, 2020
Merged

Conversation

esbanarango
Copy link
Contributor

This PR fixes #22

@ijlee2 ijlee2 force-pushed the esbanarango/fix-#22 branch from d180a82 to eae2671 Compare November 7, 2020 18:58
@ijlee2
Copy link
Member

ijlee2 commented Nov 7, 2020

I rebased the branch so that the pull request will be checked against GitHub Actions instead of Travis.

@ijlee2 ijlee2 requested a review from a team November 7, 2020 18:59
@esbanarango
Copy link
Contributor Author

@rwwagner90 comment addressed. Thank you

Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@esbanarango I think making the param default to '' is all we need right?

@RobbieTheWagner RobbieTheWagner merged commit 4963311 into ember-learn:master Nov 16, 2020
@RobbieTheWagner RobbieTheWagner added the bug Something isn't working label Nov 16, 2020
@esbanarango esbanarango deleted the esbanarango/fix-#22 branch November 17, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'replace' of undefined
3 participants