Skip to content

Support larger discovery characterisrics maximum buffer size #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexmoon merged 2 commits into from
Jun 26, 2025
Merged

Support larger discovery characterisrics maximum buffer size #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d98d9e9
Increase DISC_CHARS_MAX.
tmpfs Jun 8, 2025
36e7016
Add discovery-chars-12 feature flag.
tmpfs Jun 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions nrf-softdevice/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ ble-l2cap-credit-workaround = []
evt-max-size-256 = []
evt-max-size-512 = []

# Support more discovery characteristics in GATT clients,
# may be needed with higher ATT_MTU and peripherals with
# many service characteristics
discovery-chars-12 = []

[dependencies]
defmt = { version = "0.3", optional = true }
log = { version = "0.4.11", optional = true }
Expand Down
4 changes: 4 additions & 0 deletions nrf-softdevice/src/ble/gatt_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,11 @@ impl From<RawError> for DiscoverError {
}
}

#[cfg(not(feature = "discovery-chars-12"))]
const DISC_CHARS_MAX: usize = 6;
#[cfg(feature = "discovery-chars-12")]
const DISC_CHARS_MAX: usize = 12;

const DISC_DESCS_MAX: usize = 6;

pub(crate) async fn discover_service(conn: &Connection, uuid: Uuid) -> Result<raw::ble_gattc_service_t, DiscoverError> {
Expand Down