Add macros feature #286
Merged
Add macros feature #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looks like the build is failing on an unrelated lint error for references to mutable statics. I believe that used to be a warning but became disallowed recently |
Contributor
Author
|
Nevermind, it's still a warning (until the 2024 edition), but warnings are denied in the CI |
Contributor
|
The master branch has been updated to resolve the warnings. Please rebase your PR onto the new master branch so that CI can pass. |
Contributor
Author
|
Thanks for all your hard work, have updated it now |
alexmoon
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
This adds a (default on)
macrosfeature to enable proc macro exports. This would allow users to remove nrf-softdevice-macro and reduce dependencies when they are not needed.Hopefully this is ok, let me know if any changes are needed!