Fix incorrect remaining bytes #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakilangit
force-pushed
the
fix_incorrect_remaining_bytes
branch
3 times, most recently
from
bd0b6bf to
9487005
Compare
kakilangit
force-pushed
the
fix_incorrect_remaining_bytes
branch
2 times, most recently
from
59af956 to
2d7e6bd
Compare
kakilangit
force-pushed
the
fix_incorrect_remaining_bytes
branch
from
2d7e6bd to
0eae9b3
Compare
Collaborator
|
Thanks! Yes, anything you want to add to support classic commands and events would be very welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi maintainers,
I realized I was using
RemainingBytesincorrectly. Please review this fix. Since this affects theInquiryResultandInquiryResultWithRssievents, I implemented an iterator for efficient parsing.Since I use this crate extensively in my projects, if you'd like, I plan to complete the commands and events, at least for classic Bluetooth (BR/EDR). Wdyt?