lsp-code-actions: display actions of the current diagnostics #4848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this breaks for me, because |
|
I have temporarily reverted it in b96102c. 🤔 |
|
Note: I'm using LSP_USE_PLISTS (as suggested for performance) |
Yeah, I completely forgot about this! I apologize! 😓 |
|
@corecode: Can you kindly test if this new PR works for you? https://github.com/emacs-lsp/lsp-mode/pull/4849/files FYI, I tested and it works on my end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR enables lsp-code-actions to display more actions if there are diagnostics at the current point.
For example, in the screenshot below, there is a warning that
format!("{}", e)can be refactored toformat!("{e}"), but when putting the cursor at the beginning of this text (at theformatstatement), there is no code action to perform such refactoring.I fixed this issue by finding the code range of the diagnostics and displaying all their code actions, so that the code action to refactor to
format!("{e}")can be displayed like below:Please consider merging it!
Thanks!