Support for haskell-ts-mode

[ScamChamp]

I had quick skim through code, and it seems like no feature from haskell mode is strictly required by lsp haskell that would be a big effort to change.
https://codeberg.org/pranshu/haskell-ts-mode

[michaelpj]

Sure, I'd take a PR for this.

[magthe]

This would also address #181 .

[ScamChamp]

I did manage to find this: magthe@2084ff1 . Can you see any problems with it?

[magthe]

Well, it does replace all mentions of haskell-mode with haskell-ng-mode (my own attempt at a new mode for Haskell), so I'm guessing it won't work well with anything else.

I have since adjusted my change so that it

1. removes the the requirement on haskell-mode, and
2. adds mentions of haskell-ng-mode.

You can find it here. So far I've seen no problems with it.

I made a small addition on top of that, adding mentions of haskell-ts-mode as well, so you can more easily see if it'll work for you as well, @ScamChamp . magthe@e9d0f8a

[ScamChamp]

Thanks magthe, I adapted the code to make it work for haskell-ts-mode. I personally don't use lsp-haskell, but lack of lsp support is an issue for some people.

@michaelpj This patch adds support for haskell-ts-mode

[magthe]

Maybe it 's worth clarifying that I removed the requirement on haskell-mode, but left all the settings with it (putthing its modes in the various lists). I believe that'll keep lsp-haskell working with haskell-mode, but that needs verifying.

Then adding support for other Haskell modes is just a matter of adding them to the various list.

[michaelpj]

If someone can put up a PR and verify that it works with all three modes then I'm happy to merge it.

[dschrempf]

I am a bit confused about the status of haskell-ts-mode support. There is a PR adding support for haskell-ts-mode: #189, but it does not remove the requirement for haskell-mode.

Then, there is a commit magthe@e9d0f8a which also removes the requirement, but I think it never got merged.

EDIT: I think lsp-haskell should not require any specific Haskell mode. The mode should be chosen by the user.

[magthe]

@dschrempf , reading the code it looks like haskell-ts-mode is supported already, but the requirement on haskell-mode is still present and will thus have to be installed too. Maybe you can try adding magthe@4f319bd to your setup to see if it's all right to remove the requirement for haskell-mode.

I think that's the kind of feedback @michaelpj would really appreciate.

[dschrempf]

See #193. Everything seems to work fine here.