Skip to content

refactor!: scope lsp options under elixirls key #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Conversation

mhanberg
Copy link
Collaborator

@mhanberg mhanberg commented Apr 12, 2023

When setting up elixir-ls, one should now scope all of the opts under an
elixirls key in the opts table.

Old:

local elixir = require("elixir")

elixir.setup {
  settings = {
    -- some settings
  }
}

New:

local elixir = require("elixir")

elixir.setup {
  elixirls = {
    settings = {
      -- some settings
    }
  }
}

In addition, the function to merge settings into the default settings
now lives in the elixirls module

Old:

local elixir = require("elixir")

elixir.settings {
  -- some settings
}

New:

local elixirls = require("elixir.elixirls")

elixirls.settings {
  -- some settings
}

@mhanberg mhanberg changed the title refactor!: refactor!: scope lsp options under elixirls key refactor!: scope lsp options under elixirls key Apr 12, 2023
When setting up elixir-ls, one should now scope all of the opts under an
`elixirls` key in the opts table.

Old:

```lua
local elixir = require("elixir")

elixir.setup {
  settings = {
    -- some settings
  }
}
```

New:

```lua
local elixir = require("elixir")

elixir.setup {
  elixirls = {
    settings = {
      -- some settings
    }
  }
}
```

In addition, the function to merge settings into the default settings
now lives in the elixirls module

Old:

```elixir
local elixir = require("elixir")

elixir.settings {
  -- some settings
}
```

New:

```elixir
local elixirls = require("elixir.elixirls")

elixirls.settings {
  -- some settings
}
```
@mhanberg mhanberg force-pushed the mh/rename-elixir-ls branch from 6b42953 to 6496f10 Compare April 12, 2023 03:11
@mhanberg mhanberg merged commit e0f7c1e into main Apr 12, 2023
@mhanberg mhanberg deleted the mh/rename-elixir-ls branch April 12, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant