-
-
Notifications
You must be signed in to change notification settings - Fork 69
fix: number format exception during data batch processing #2272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: number format exception during data batch processing #2272
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2272 +/- ##
============================================
+ Coverage 16.72% 16.74% +0.02%
- Complexity 444 448 +4
============================================
Files 252 252
Lines 7325 7339 +14
Branches 816 830 +14
============================================
+ Hits 1225 1229 +4
- Misses 6045 6049 +4
- Partials 55 61 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Caution Review failedThe pull request is closed. """ WalkthroughThe changes introduce null and blank checks for the "research_experiment" and "experiment_group" fields in CSV event extraction methods to prevent NumberFormatException when these fields are empty. A new test verifies correct extraction behavior for CSV files with missing experiment data. The Maven dependency tree version was also updated. Changes
Sequence Diagram(s)sequenceDiagram
participant Test as CsvAnalyticsExtractionHelperTest
participant Helper as CsvAnalyticsExtractionHelper
participant CSV as CSV File
Test->>Helper: extractLetterSoundLearningEvents(CSV)
Helper->>CSV: Read record
alt research_experiment and experiment_group present
Helper->>Helper: Parse and set experiment fields
else fields blank or null
Helper->>Helper: Skip setting experiment fields
end
Helper-->>Test: Return extracted events
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Issue Number
Purpose
Technical Details
Testing Instructions
Screenshots
Format Checks
Note
Files in PRs are automatically checked for format violations with
mvn spotless:check
.If this PR contains files with format violations, run
mvn spotless:apply
to fix them.