-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
MVVM - Introduce the concept of disposables to track event listeners, sub vms and so on #30475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MidhunSureshR
wants to merge
9
commits into
develop
Choose a base branch
from
midhun/mvvm/state-management-2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e8d870
to
d86dcb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the dispose function is never called for the two vms (AudioPlayer & TextuamEvent). For AudioPlayer, you can call in the unmount of the MAudioBody
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on from #30398
Previously,
SubscriptionViewModel
had the following mechanism for adding/removing any event listeners that the vm needs:This means that the vm only listens to any relevant events (that it needs to keep its state correct) as long as there is at least one view subscribed to it. This is a problem because if the view unmounts and then mounts again, meaning that it goes through
subscribe -> unsubscribe -> subscribe
, the view model can present the wrong state because it wasn't listening to relevant events. Therefore, the lifetime of the event listeners should equal the lifetime of the view model itself.Issue is illustrated here: https://github.com/element-hq/element-web/blob/c64104ffeea69da579ad601f9a4e0af8624e05a9/src/shared-components/ViewModelSubIssueDemo.test.tsx
This PR borrows the concept of
Disposables
from hydrogen:It provides a way to track any resource that needs to be relinquished eventually. This will usually be sub view models or event listeners.
Whoever creates the view model has the responsibility to call
dispose()
method on it to indicate that it is no longer needed.Tracking sub view-models
Tracking event listeners