Skip to content

Log *what* components trigger a grype scan #17905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025

Conversation

donoghuc
Copy link
Member

@donoghuc donoghuc commented Aug 1, 2025

This commit updates the grype action to log what components it is scanning (including any that are critical which will cause the action to fail). Previously the default sarif file was generated and nothing was logged. Without this commit it is impossible to tell from a failed action what is causing the failure.

See https://github.com/anchore/scan-action?tab=readme-ov-file#action-inputs which indicates this option should do what we want.

This commit updates the grype action to log what components it is scanning
(including any that are critical which will cause the action to fail).
Previously the default sarif file was generated and nothing was logged. Without
this commit it is impossible to tell from a failed action *what* is causing the
failure.
@donoghuc donoghuc requested review from a team as code owners August 1, 2025 23:06
Copy link
Contributor

github-actions bot commented Aug 1, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

mergify bot commented Aug 1, 2025

This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

@donoghuc donoghuc added the backport-active-all Automated backport with mergify to all the active branches label Aug 1, 2025
Copy link

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donoghuc donoghuc merged commit 6b8d090 into elastic:main Aug 4, 2025
12 checks passed
Copy link
Contributor

github-actions bot commented Aug 4, 2025

@Mergifyio backport 8.17 8.18 8.19 9.0 9.1

Copy link
Contributor

mergify bot commented Aug 4, 2025

backport 8.17 8.18 8.19 9.0 9.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 4, 2025
This commit updates the grype action to log what components it is scanning
(including any that are critical which will cause the action to fail).
Previously the default sarif file was generated and nothing was logged. Without
this commit it is impossible to tell from a failed action *what* is causing the
failure.

(cherry picked from commit 6b8d090)
mergify bot pushed a commit that referenced this pull request Aug 4, 2025
This commit updates the grype action to log what components it is scanning
(including any that are critical which will cause the action to fail).
Previously the default sarif file was generated and nothing was logged. Without
this commit it is impossible to tell from a failed action *what* is causing the
failure.

(cherry picked from commit 6b8d090)
mergify bot pushed a commit that referenced this pull request Aug 4, 2025
This commit updates the grype action to log what components it is scanning
(including any that are critical which will cause the action to fail).
Previously the default sarif file was generated and nothing was logged. Without
this commit it is impossible to tell from a failed action *what* is causing the
failure.

(cherry picked from commit 6b8d090)
mergify bot pushed a commit that referenced this pull request Aug 4, 2025
This commit updates the grype action to log what components it is scanning
(including any that are critical which will cause the action to fail).
Previously the default sarif file was generated and nothing was logged. Without
this commit it is impossible to tell from a failed action *what* is causing the
failure.

(cherry picked from commit 6b8d090)
mergify bot pushed a commit that referenced this pull request Aug 4, 2025
This commit updates the grype action to log what components it is scanning
(including any that are critical which will cause the action to fail).
Previously the default sarif file was generated and nothing was logged. Without
this commit it is impossible to tell from a failed action *what* is causing the
failure.

(cherry picked from commit 6b8d090)
donoghuc added a commit that referenced this pull request Aug 4, 2025
This commit updates the grype action to log what components it is scanning
(including any that are critical which will cause the action to fail).
Previously the default sarif file was generated and nothing was logged. Without
this commit it is impossible to tell from a failed action *what* is causing the
failure.

(cherry picked from commit 6b8d090)

Co-authored-by: Cas Donoghue <[email protected]>
donoghuc added a commit that referenced this pull request Aug 4, 2025
This commit updates the grype action to log what components it is scanning
(including any that are critical which will cause the action to fail).
Previously the default sarif file was generated and nothing was logged. Without
this commit it is impossible to tell from a failed action *what* is causing the
failure.

(cherry picked from commit 6b8d090)

Co-authored-by: Cas Donoghue <[email protected]>
donoghuc added a commit that referenced this pull request Aug 4, 2025
This commit updates the grype action to log what components it is scanning
(including any that are critical which will cause the action to fail).
Previously the default sarif file was generated and nothing was logged. Without
this commit it is impossible to tell from a failed action *what* is causing the
failure.

(cherry picked from commit 6b8d090)

Co-authored-by: Cas Donoghue <[email protected]>
donoghuc added a commit that referenced this pull request Aug 4, 2025
This commit updates the grype action to log what components it is scanning
(including any that are critical which will cause the action to fail).
Previously the default sarif file was generated and nothing was logged. Without
this commit it is impossible to tell from a failed action *what* is causing the
failure.

(cherry picked from commit 6b8d090)

Co-authored-by: Cas Donoghue <[email protected]>
donoghuc added a commit that referenced this pull request Aug 4, 2025
This commit updates the grype action to log what components it is scanning
(including any that are critical which will cause the action to fail).
Previously the default sarif file was generated and nothing was logged. Without
this commit it is impossible to tell from a failed action *what* is causing the
failure.

(cherry picked from commit 6b8d090)

Co-authored-by: Cas Donoghue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-active-all Automated backport with mergify to all the active branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants