-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[Security Solution] Enable new flyout navigation flag #211330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Enable new flyout navigation flag #211330
Conversation
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
desk tested and code LGTM!
@christineweng as this PR enables the new flyout navigation by default does this deserve a release note entry? I notice you have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Thanks @hop-dev for the review! The original PRs (#184970, #204292) are marked |
Starting backport for target branches: 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13420900782 |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
## Summary Changed `newExpandableFlyoutNavigationEnabled` to `newExpandableFlyoutNavigationDisabled`. The flyout history and preview navigation are now enabled by default. Default (`newExpandableFlyoutNavigationDisabled` off) - History icon show up in flyout - Links in preview will open a new flyout https://github.com/user-attachments/assets/10f558fa-3c4c-4718-9f7e-cce6a19ead8b `newExpandableFlyoutNavigationDisabled` on - No history shown - Title links in preview disabled https://github.com/user-attachments/assets/fcd6ab33-5c88-4c5b-b0c5-02cbcf14c40d ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit e3f166b)
## Summary Changed `newExpandableFlyoutNavigationEnabled` to `newExpandableFlyoutNavigationDisabled`. The flyout history and preview navigation are now enabled by default. Default (`newExpandableFlyoutNavigationDisabled` off) - History icon show up in flyout - Links in preview will open a new flyout https://github.com/user-attachments/assets/10f558fa-3c4c-4718-9f7e-cce6a19ead8b `newExpandableFlyoutNavigationDisabled` on - No history shown - Title links in preview disabled https://github.com/user-attachments/assets/fcd6ab33-5c88-4c5b-b0c5-02cbcf14c40d ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit e3f166b)
## Summary Changed `newExpandableFlyoutNavigationEnabled` to `newExpandableFlyoutNavigationDisabled`. The flyout history and preview navigation are now enabled by default. Default (`newExpandableFlyoutNavigationDisabled` off) - History icon show up in flyout - Links in preview will open a new flyout https://github.com/user-attachments/assets/10f558fa-3c4c-4718-9f7e-cce6a19ead8b `newExpandableFlyoutNavigationDisabled` on - No history shown - Title links in preview disabled https://github.com/user-attachments/assets/fcd6ab33-5c88-4c5b-b0c5-02cbcf14c40d ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit e3f166b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…#211839) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Enable new flyout navigation flag (#211330)](#211330) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-19T19:36:12Z","message":"[Security Solution] Enable new flyout navigation flag (#211330)\n\n## Summary\n\nChanged `newExpandableFlyoutNavigationEnabled` to\n`newExpandableFlyoutNavigationDisabled`. The flyout history and preview\nnavigation are now enabled by default.\n\nDefault (`newExpandableFlyoutNavigationDisabled` off)\n- History icon show up in flyout\n- Links in preview will open a new flyout\n\n\n\nhttps://github.com/user-attachments/assets/10f558fa-3c4c-4718-9f7e-cce6a19ead8b\n\n\n\n`newExpandableFlyoutNavigationDisabled` on\n- No history shown\n- Title links in preview disabled\n\n\n\nhttps://github.com/user-attachments/assets/fcd6ab33-5c88-4c5b-b0c5-02cbcf14c40d\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"e3f166b70c85d730b15194f477db14d510043a82","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Enable new flyout navigation flag","number":211330,"url":"https://github.com/elastic/kibana/pull/211330","mergeCommit":{"message":"[Security Solution] Enable new flyout navigation flag (#211330)\n\n## Summary\n\nChanged `newExpandableFlyoutNavigationEnabled` to\n`newExpandableFlyoutNavigationDisabled`. The flyout history and preview\nnavigation are now enabled by default.\n\nDefault (`newExpandableFlyoutNavigationDisabled` off)\n- History icon show up in flyout\n- Links in preview will open a new flyout\n\n\n\nhttps://github.com/user-attachments/assets/10f558fa-3c4c-4718-9f7e-cce6a19ead8b\n\n\n\n`newExpandableFlyoutNavigationDisabled` on\n- No history shown\n- Title links in preview disabled\n\n\n\nhttps://github.com/user-attachments/assets/fcd6ab33-5c88-4c5b-b0c5-02cbcf14c40d\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"e3f166b70c85d730b15194f477db14d510043a82"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211330","number":211330,"mergeCommit":{"message":"[Security Solution] Enable new flyout navigation flag (#211330)\n\n## Summary\n\nChanged `newExpandableFlyoutNavigationEnabled` to\n`newExpandableFlyoutNavigationDisabled`. The flyout history and preview\nnavigation are now enabled by default.\n\nDefault (`newExpandableFlyoutNavigationDisabled` off)\n- History icon show up in flyout\n- Links in preview will open a new flyout\n\n\n\nhttps://github.com/user-attachments/assets/10f558fa-3c4c-4718-9f7e-cce6a19ead8b\n\n\n\n`newExpandableFlyoutNavigationDisabled` on\n- No history shown\n- Title links in preview disabled\n\n\n\nhttps://github.com/user-attachments/assets/fcd6ab33-5c88-4c5b-b0c5-02cbcf14c40d\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"e3f166b70c85d730b15194f477db14d510043a82"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <[email protected]>
…#211840) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] Enable new flyout navigation flag (#211330)](#211330) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-19T19:36:12Z","message":"[Security Solution] Enable new flyout navigation flag (#211330)\n\n## Summary\n\nChanged `newExpandableFlyoutNavigationEnabled` to\n`newExpandableFlyoutNavigationDisabled`. The flyout history and preview\nnavigation are now enabled by default.\n\nDefault (`newExpandableFlyoutNavigationDisabled` off)\n- History icon show up in flyout\n- Links in preview will open a new flyout\n\n\n\nhttps://github.com/user-attachments/assets/10f558fa-3c4c-4718-9f7e-cce6a19ead8b\n\n\n\n`newExpandableFlyoutNavigationDisabled` on\n- No history shown\n- Title links in preview disabled\n\n\n\nhttps://github.com/user-attachments/assets/fcd6ab33-5c88-4c5b-b0c5-02cbcf14c40d\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"e3f166b70c85d730b15194f477db14d510043a82","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Enable new flyout navigation flag","number":211330,"url":"https://github.com/elastic/kibana/pull/211330","mergeCommit":{"message":"[Security Solution] Enable new flyout navigation flag (#211330)\n\n## Summary\n\nChanged `newExpandableFlyoutNavigationEnabled` to\n`newExpandableFlyoutNavigationDisabled`. The flyout history and preview\nnavigation are now enabled by default.\n\nDefault (`newExpandableFlyoutNavigationDisabled` off)\n- History icon show up in flyout\n- Links in preview will open a new flyout\n\n\n\nhttps://github.com/user-attachments/assets/10f558fa-3c4c-4718-9f7e-cce6a19ead8b\n\n\n\n`newExpandableFlyoutNavigationDisabled` on\n- No history shown\n- Title links in preview disabled\n\n\n\nhttps://github.com/user-attachments/assets/fcd6ab33-5c88-4c5b-b0c5-02cbcf14c40d\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"e3f166b70c85d730b15194f477db14d510043a82"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211330","number":211330,"mergeCommit":{"message":"[Security Solution] Enable new flyout navigation flag (#211330)\n\n## Summary\n\nChanged `newExpandableFlyoutNavigationEnabled` to\n`newExpandableFlyoutNavigationDisabled`. The flyout history and preview\nnavigation are now enabled by default.\n\nDefault (`newExpandableFlyoutNavigationDisabled` off)\n- History icon show up in flyout\n- Links in preview will open a new flyout\n\n\n\nhttps://github.com/user-attachments/assets/10f558fa-3c4c-4718-9f7e-cce6a19ead8b\n\n\n\n`newExpandableFlyoutNavigationDisabled` on\n- No history shown\n- Title links in preview disabled\n\n\n\nhttps://github.com/user-attachments/assets/fcd6ab33-5c88-4c5b-b0c5-02cbcf14c40d\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"e3f166b70c85d730b15194f477db14d510043a82"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <[email protected]>
#211838) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Enable new flyout navigation flag (#211330)](#211330) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-19T19:36:12Z","message":"[Security Solution] Enable new flyout navigation flag (#211330)\n\n## Summary\n\nChanged `newExpandableFlyoutNavigationEnabled` to\n`newExpandableFlyoutNavigationDisabled`. The flyout history and preview\nnavigation are now enabled by default.\n\nDefault (`newExpandableFlyoutNavigationDisabled` off)\n- History icon show up in flyout\n- Links in preview will open a new flyout\n\n\n\nhttps://github.com/user-attachments/assets/10f558fa-3c4c-4718-9f7e-cce6a19ead8b\n\n\n\n`newExpandableFlyoutNavigationDisabled` on\n- No history shown\n- Title links in preview disabled\n\n\n\nhttps://github.com/user-attachments/assets/fcd6ab33-5c88-4c5b-b0c5-02cbcf14c40d\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"e3f166b70c85d730b15194f477db14d510043a82","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Enable new flyout navigation flag","number":211330,"url":"https://github.com/elastic/kibana/pull/211330","mergeCommit":{"message":"[Security Solution] Enable new flyout navigation flag (#211330)\n\n## Summary\n\nChanged `newExpandableFlyoutNavigationEnabled` to\n`newExpandableFlyoutNavigationDisabled`. The flyout history and preview\nnavigation are now enabled by default.\n\nDefault (`newExpandableFlyoutNavigationDisabled` off)\n- History icon show up in flyout\n- Links in preview will open a new flyout\n\n\n\nhttps://github.com/user-attachments/assets/10f558fa-3c4c-4718-9f7e-cce6a19ead8b\n\n\n\n`newExpandableFlyoutNavigationDisabled` on\n- No history shown\n- Title links in preview disabled\n\n\n\nhttps://github.com/user-attachments/assets/fcd6ab33-5c88-4c5b-b0c5-02cbcf14c40d\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"e3f166b70c85d730b15194f477db14d510043a82"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211330","number":211330,"mergeCommit":{"message":"[Security Solution] Enable new flyout navigation flag (#211330)\n\n## Summary\n\nChanged `newExpandableFlyoutNavigationEnabled` to\n`newExpandableFlyoutNavigationDisabled`. The flyout history and preview\nnavigation are now enabled by default.\n\nDefault (`newExpandableFlyoutNavigationDisabled` off)\n- History icon show up in flyout\n- Links in preview will open a new flyout\n\n\n\nhttps://github.com/user-attachments/assets/10f558fa-3c4c-4718-9f7e-cce6a19ead8b\n\n\n\n`newExpandableFlyoutNavigationDisabled` on\n- No history shown\n- Title links in preview disabled\n\n\n\nhttps://github.com/user-attachments/assets/fcd6ab33-5c88-4c5b-b0c5-02cbcf14c40d\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"e3f166b70c85d730b15194f477db14d510043a82"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <[email protected]>
## Summary Changed `newExpandableFlyoutNavigationEnabled` to `newExpandableFlyoutNavigationDisabled`. The flyout history and preview navigation are now enabled by default. Default (`newExpandableFlyoutNavigationDisabled` off) - History icon show up in flyout - Links in preview will open a new flyout https://github.com/user-attachments/assets/10f558fa-3c4c-4718-9f7e-cce6a19ead8b `newExpandableFlyoutNavigationDisabled` on - No history shown - Title links in preview disabled https://github.com/user-attachments/assets/fcd6ab33-5c88-4c5b-b0c5-02cbcf14c40d ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
Summary
Changed
newExpandableFlyoutNavigationEnabled
tonewExpandableFlyoutNavigationDisabled
. The flyout history and preview navigation are now enabled by default.Default (
newExpandableFlyoutNavigationDisabled
off)Screen.Recording.2025-02-14.at.4.22.01.PM.mov
newExpandableFlyoutNavigationDisabled
onScreen.Recording.2025-02-14.at.4.20.36.PM.mov
Checklist
release_note:*
label is applied per the guidelines