-
Notifications
You must be signed in to change notification settings - Fork 2
Change logs sub-profile naming from underscore to dot notation #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change logs sub-profile naming from underscore to dot notation #14
Conversation
Co-authored-by: kertal <[email protected]>
|
@copilot how can I test the dev instance locally |
To test the renamed log files locally with your Kibana dev instance:
The scripts are configured to connect to |
|
@copilot i want to test with curl directly from the development branch |
To test directly from your development branch using curl, use the raw GitHub URL: curl -sSL https://raw.githubusercontent.com/elastic/kibana-demo-data/copilot/fix-4a2cd73d-c586-48ed-af20-e983a898909e/all.sh | sh -s customThis will:
The script expects Elasticsearch on |
|
@copilot rename logs-k8s_container to logs-kubernetes.container_logs |
Co-authored-by: kertal <[email protected]>
kertal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR changes the naming convention for logs sub-profiles from underscore separators to dot separators for contextual profile configuration names, as requested in the issue.
Changes Made
Data File Renames:
logs-{provider}_{subname}.ndjsontologs-{provider}.{subname}.ndjsonlogs-{provider}_{subname}_mappings.jsontologs-{provider}.{subname}_mappings.jsonShell Script Updates:
god.sh(24 references)scripts/custom.sh(14 references)Profile Name Mappings
The following profile names have been updated:
logs-apache_errorlogs-apache.errorlogs-aws_s3logs-aws.s3logs-custom_multiplexlogs-custom.multiplexlogs-k8s_containerlogs-kubernetes.container_logslogs-nginx_errorlogs-nginx.errorlogs-system_errorlogs-system.errorImplementation Details
The changes maintain full backward compatibility:
"event.dataset": "apache.error","event.dataset": "kubernetes.container")This brings the file naming convention in line with the contextual profile configuration naming standards while preserving the integrity of the demo data.
This pull request was created as a result of the following prompt from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.