Skip to content

Conversation

chrisberkhout
Copy link
Contributor

Proposed commit message

[proofpoint_tap] Clean up null handling (#)

- Combine 'is null or not contains' checks.
- Combine 'not null and is/not value' checks.
- Remove redundant null-safe operator.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@chrisberkhout chrisberkhout added Integration:proofpoint_tap Proofpoint TAP Team:Service-Integrations Label for the Observability Service Integrations team bugfix Pull request that fixes a bug issue labels Feb 14, 2024
@chrisberkhout chrisberkhout self-assigned this Feb 14, 2024
@chrisberkhout chrisberkhout requested a review from a team as a code owner February 14, 2024 16:54
@elasticmachine
Copy link

🚀 Benchmarks report

Package proofpoint_tap 👍(0) 💚(3) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
message_delivered 2923.98 2331 -592.98 (-20.28%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @chrisberkhout

Copy link

@chrisberkhout chrisberkhout merged commit 87e6e91 into elastic:main Feb 15, 2024
@chrisberkhout chrisberkhout deleted the proofpoint_tap-null-handling branch February 15, 2024 08:16
@elasticmachine
Copy link

Package proofpoint_tap - 1.16.3 containing this change is available at https://epr.elastic.co/search?package=proofpoint_tap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:proofpoint_tap Proofpoint TAP Team:Service-Integrations Label for the Observability Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants