Skip to content

snyk: add attributes.{ignored,status,updated_at} field values to fingerprint #14989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

snyk: add attributes.{ignored,status,updated_at} field values to fingerprint #14989

wants to merge 1 commit into from
+10 −1

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Aug 19, 2025

Proposed commit message

See title.

This is a resurrection of #14430.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Aug 19, 2025
@efd6 efd6 added enhancement New feature or request Integration:snyk Snyk Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Aug 19, 2025
@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review August 20, 2025 00:16
@efd6 efd6 requested a review from a team as a code owner August 20, 2025 00:16
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@clement-fouque
Copy link
Contributor

I'm not able to validate it's working as expecting since I still have this issue: #14342

@clement-fouque
Copy link
Contributor

After some more investigation, I'm blocked with this new issue: #15006

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisberkhout chrisberkhout chrisberkhout approved these changes

@clement-fouque clement-fouque Awaiting requested review from clement-fouque

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:snyk Snyk Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[snyk]: Fingerprint should include the status
4 participants
@efd6 @elasticmachine @clement-fouque @chrisberkhout