[zscaler_zpa] Cleanup empty field from json to avoid errors #14493
+135
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
Integration:zscaler_zpa
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
andrewkroh
reviewed
Jul 10, 2025
packages/zscaler_zpa/data_stream/app_connector_status/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
packages/zscaler_zpa/data_stream/audit/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
packages/zscaler_zpa/data_stream/browser_access/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
packages/zscaler_zpa/data_stream/user_activity/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
packages/zscaler_zpa/data_stream/user_status/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
…onKoetting/integrations into zscaler_zpa_remove_empty_json_values
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
app_connector_status |
0 | 1572.33 | 1572.33 ( - %) | 👍 |
audit |
0 | 3937.01 | 3937.01 ( - %) | 👍 |
browser_access |
0 | 1814.88 | 1814.88 ( - %) | 👍 |
user_activity |
0 | 2958.58 | 2958.58 ( - %) | 👍 |
user_status |
0 | 5847.95 | 5847.95 ( - %) | 👍 |
efd6
reviewed
Jul 10, 2025
|
/test benchmark fullreport |
💚 Build Succeeded
History
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zscaler uses a template language to send logs. As a result, it's possible for a
field in the JSON we receive to exist but have an empty string as its value.
For date processors in the pipeline, this issue has already been addressed
using conditions like
ctx.json?.LogTimestamp != null && ctx.json.LogTimestamp != ''.However, we encountered a problem with a user where a non-date field failed
to convert to an IP address due to the error message:
'' is not an IP string literal.To prevent this from happening with any field, I propose adding a cleanup step
at the beginning of the pipeline in this PR. This would handle all empty fields
directly, allowing us to rely on the
ignore_missingoption instead of addingmultiple conditions like
[field] != null && [field] != ''for each processor.