Skip to content

[Forgerock] Add dashboard filter #14484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

moxarth-rathod
Copy link
Contributor

@moxarth-rathod moxarth-rathod commented Jul 10, 2025

Proposed commit message

forgerock: add filter to populate the dashboard specific to Forgerock data

This PR has added a filter - `dataset.data_stream.dataset: forgerock.*` for the panel where the filter
was not present. Now, these panels will be populated with specific to Forgerock data.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

Screenshots

image

@moxarth-rathod moxarth-rathod self-assigned this Jul 10, 2025
@moxarth-rathod moxarth-rathod requested a review from a team as a code owner July 10, 2025 10:38
@moxarth-rathod moxarth-rathod added bugfix Pull request that fixes a bug issue Integration:forgerock ForgeRock Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Jul 10, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link

@elasticmachine
Copy link

💚 Build Succeeded

cc @moxarth-rathod

@andrewkroh andrewkroh added the dashboard Relates to a Kibana dashboard bug, enhancement, or modification. label Jul 10, 2025
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moxarth-rathod Can you provide screenshot for before and after the change that demonstrate the fix?

@moxarth-rathod
Copy link
Contributor Author

@moxarth-rathod Can you provide screenshot for before and after the change that demonstrate the fix?

@efd6 there’s no visual change to the dashboard because filters are applied to individual panels rather than the entire dashboard.

@efd6
Copy link
Contributor

efd6 commented Jul 11, 2025

What I was expecting would be looking at the forgerock dashboard assets that have been modified here when there are events that have come from other data streams and would be filtered out; before and after. We should see events in the dashboards in the before case and none in the after case.

@moxarth-rathod
Copy link
Contributor Author

moxarth-rathod commented Jul 12, 2025

What I was expecting would be looking at the forgerock dashboard assets that have been modified here when there are events that have come from other data streams and would be filtered out; before and after. We should see events in the dashboards in the before case and none in the after case.

Sure, i've captured the screenshots with the data so you can see before/after changes in the panels. You can compare the first panel of before which includes the data of other data stream but got filtered out in after screenshot.

Before
image

After
image

@moxarth-rathod moxarth-rathod requested a review from efd6 July 12, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:forgerock ForgeRock Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forgerock: dashboard does not properly filter documents to be specific for ForgeRock data
4 participants