[EUI Data Grid / Table] Colors and hover effect

[ek-so]

Context

During Borealis rollout, we fixed the colors quickly, but it resulted in:

• having many greys on data grid, which doesn't look particularly neat and doesn't add much clarity
• for tables, on the contrary, we lost hover effect for already selected rows, and there was a fb asking to bring it back
• plus it would be great if we could get rid of overrides of original EUI styles, considering use cases in Kibana, so that it works out of the box.

Proposal

For simple tables

• The hover effect for regular row stays as is (it’s bg-interactive-hover, 4% primary-100);
• For already selected row we add a special hover color (primary-20)

For data grid

• We treat 2 types of layouts, plain/simple and striped, differently:
  • For simple layout, there’s all the same as for the table;
  • For the striped version, remove the background color change on hover for rows. The reason is, that such rows are already visually distinct due to their alternating colors (and we still retain a frame on hover for the particular cell). This makes it easy to follow with the eyes while reducing unnecessary color variation.
    

[ek-so]

Hey @andreadelrio, could you please share your thoughts on this? We had a discussion in slack which resulted in this proposal here. There was also a question, if we can remove striping in Discover entirely to simplify the color schema? I assume, it's unlikely, but wanted to get your confirmation.

[andreadelrio]

@ek-so I agree with the proposed changes. As for the possibility to remove stripping, as Michael mentioned, we need it in Discover as it helps users parse the data. You can see more background behind this decision on this issue.

[ek-so]

We're planning to proceed with on EUI side, as suggested.