Aggregations Refactor: Refactor Moving Average Aggregation #15180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colings86
force-pushed
the
feature/aggs-refactoring
branch
from
cd3937d to
f386661
Compare
|
|
||
| protected ValueFormatter formatter() { | ||
| if (format != null) { | ||
| return ValueFormat.Patternable.Number.format(format).formatter(); |
There was a problem hiding this comment.
I don't know how often this is called, depending on this maybe it makes sense to store the formatter somewhere for later reuse unless format changes? Is only called a few times maybe not worth the trouble.
|
Left a few small comments, would improve readability if readFrom/writeTo for the Models would be somehow symetric, but maybe that's hard to achieve with the current serialization infra. Otherwise looks good to me. |
|
LGTM |
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.