Fix AutoDateHistogram RoundingInfo equals/hashCode to include all serialized fields#151156
Open
junhyeong9812 wants to merge 2 commits into
Open
Fix AutoDateHistogram RoundingInfo equals/hashCode to include all serialized fields#151156junhyeong9812 wants to merge 2 commits into
junhyeong9812 wants to merge 2 commits into
Conversation
RoundingInfo serializes roughEstimateDurationMillis and unitAbbreviation but equals()/hashCode() omitted them, so instances differing only in those fields compared equal. Include both and add a regression test. This also fixes RoundingInfo[] deep equality used in InternalAutoDateHistogram.
elasticsearchmachine
added
external-contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoDateHistogramAggregationBuilder.RoundingInfoserializes five fields inwriteTo(rounding,roughEstimateDurationMillis,innerIntervals,unitAbbreviation,dateTimeUnit) but itsequals()/hashCode()only consider three of them, omittingroughEstimateDurationMillis(along) andunitAbbreviation(aString). TwoRoundingInfoinstances that differ only in one of those serialized fields therefore compare equal and share a hash code.This includes both fields in
equals()andhashCode()and adds a regression test.RoundingInfoequality also feeds intoInternalAutoDateHistogram.BucketInfo, which comparesRoundingInfo[]via deep equality, so this also makes reduce/result equality correct.Closes #151155