Aggregations Refactor: Refactor Geo Centroid Aggregation #15002
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return new GeoCentroidAggregator.Factory(aggregationName, vsParser.input()); | ||
| protected boolean token(String aggregationName, String currentFieldName, Token token, XContentParser parser, | ||
| ParseFieldMatcher parseFieldMatcher, Map<ParseField, Object> otherOptions) throws IOException { | ||
| return false; |
There was a problem hiding this comment.
nit: Could you add some javadoc to the abstract method in AbstractValuesSourceParser for the expected behaviour for future reference? It's not so difficult to figure out when reading the parser code but especially with boolean return types, the semantics of true/false tend to get confusing.
|
@colings86 left two small comments, otherwise looks good. Again, not sure if maybe also @jpountz should take a brief look? |
|
LGTM, I just seconded @cbuescher 's request to have a bit more of javadocs. |
|
Despite what Github may think, this was successfully merged into the agg refactoring branch 68f18e9 |
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.