Aggregations Refactor: Refactor Scripted Metric Aggregation #14966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (hasParams) { | ||
| out.writeMap(params); | ||
| } | ||
| } |
There was a problem hiding this comment.
should we use writeOptionalStreamable/readOptionalStreamable for serialization instead?
colings86
force-pushed
the
feature/aggs-refactoring
branch
from
783384b to
21556f9
Compare
|
|
||
| /** | ||
| * Script holds all the parameters necessary to compile or find in cache and then execute a script. | ||
| */ | ||
| public class Script implements ToXContent, Streamable { | ||
|
|
||
| public static final Supplier<Script> SUPPLIER = new Supplier<Script>() { |
There was a problem hiding this comment.
can you add javadocs that this is for usage in conjunction with StreamInput.readStreamable?
|
LGTM |
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.