-
Notifications
You must be signed in to change notification settings - Fork 25.3k
[Backport] Mute tests in SSLErrorMessageFileTests that rely on Se… #131342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 9.0
Are you sure you want to change the base?
Conversation
Pinging @elastic/es-security (Team:Security) |
Pinging @elastic/es-core-infra (Team:Core/Infra) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests are never going to be fixed or work in 9.0/8.18.
It would be better to remove them from those branches.
@gmjehovich I'm ++ on @ldematte's suggestion a few other questions:
|
8.17 is OK, no change.
9.1 should be OK -- correct me if I'm wrong, but in 8.19/9.1/main we now have unit tests for entitlements and these test should have been updated to use it? |
@ldematte I just meant that I'm not sure our backport tool works if you open a PR against 9.0 with a 9.1 label -- I'm just assuming that the backport tool would only open backport PRs against versions lower than the branch the PR is open against. |
I can confirm that this works :) Edit: Sorry, just double checked it and it wont work. The 9.1 is not listed here: elasticsearch/.backportrc.json Line 3 in 16429d0
It would work from 9.0 to main, but not 9.0 to 9.1 |
@mosche confirmed that he fixed the tests for 8.19/9.1/main porting them to use entitlements. These tests should be now unmuted on those branches, and should be not muted again. We are not backporting unit tests support for entitlement to 8.18/9.0, so these test there will never work. I suggest we remove them. 8.17 is unchanged and uses the SM if available, which means Java < 24. |
Backport of PR #130474
References #127192 #127193 #127190