Skip to content

Adding merging logic to recursive chunking and renaming SeparatorSet to SeparatorGroup #131103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adding merging logic to recursive chunking and renaming SeparatorSet to SeparatorGroup #131103

wants to merge 3 commits into from

Conversation

dan-rubinstein
Copy link
Member

This change includes two fixes for the recursive chunking strategy:

  1. Adding logic to merge chunks together (within the maximum chunk size) after splitting a document on a given separator. This reduces the number of chunks generated if splitting document results in many small chunks.
  2. Renamed SeparatorSet to SeparatorGroup to ensure naming is clear for users.

@dan-rubinstein dan-rubinstein added >bug :ml Machine learning Team:ML Meta label for the ML team auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 v9.2.0 labels Jul 11, 2025
@dan-rubinstein dan-rubinstein marked this pull request as ready for review July 11, 2025 14:39
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine
Copy link
Collaborator

Hi @dan-rubinstein, I've created a changelog YAML for you.

@davidkyle davidkyle added >non-issue and removed >bug labels Jul 11, 2025
davidkyle
davidkyle approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkyle davidkyle davidkyle approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged :ml Machine learning >non-issue Team:ML Meta label for the ML team v8.19.0 v9.1.0 v9.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dan-rubinstein @elasticsearchmachine @davidkyle