Skip to content

Use try to close query response and unmute testThatRemoteErrorsAreWrapped #131090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pawankartik-elastic
Copy link
Contributor

@pawankartik-elastic pawankartik-elastic commented Jul 11, 2025

This test was added way back in April and there are only 5 failures out of 20,000+ executions. All these failures occurred on 8th July. I looked at the logs for a run and saw a few other test failures with error messages pointing towards certain "leaks". I suspect that these failures are isolated to that run and have nothing to do with the test itself. Nevertheless, I made a small change to close out the ES|QL response we're obtaining in the test to be on the safer side and also unmuted the test.

Resolves #130794.

@pawankartik-elastic pawankartik-elastic added >non-issue >test Issues or PRs that are addressing/adding tests Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch :Search Foundations/Search Catch all for Search Foundations v9.2.0 labels Jul 11, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@pawankartik-elastic pawankartik-elastic changed the title testThatRemoteErrorsAreWrapped: use try to close query response and unmute test Use try to close query response and unmute testThatRemoteErrorsAreWrapped Jul 11, 2025
@pawankartik-elastic pawankartik-elastic merged commit f536069 into elastic:main Jul 11, 2025
33 checks passed
pawankartik-elastic added a commit to pawankartik-elastic/elasticsearch that referenced this pull request Jul 11, 2025
…lastic#131090)

Explicitly close the ES|QL query response obtained in the test to avoid potential leak.

(cherry picked from commit f536069)

# Conflicts:
#	muted-tests.yml
@pawankartik-elastic
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.19

Questions ?

Please refer to the Backport tool documentation

elasticsearchmachine pushed a commit that referenced this pull request Jul 14, 2025
…ponse (#131090) (#131106)

* `testThatRemoteErrorsAreWrapped`: use `try` to close query response (#131090)

Explicitly close the ES|QL query response obtained in the test to avoid potential leak.

(cherry picked from commit f536069)

# Conflicts:
#	muted-tests.yml

* Fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] EsqlRemoteErrorWrapIT testThatRemoteErrorsAreWrapped failing
3 participants