-
Notifications
You must be signed in to change notification settings - Fork 25.3k
[ES|QL] Add doc for the COMPLETION command #131010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-analytical-engine (Team:Analytics) |
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main thought reading this is that "completion" is kind of a misnomer, or it's underselling the power of the command. This is really a more general-purpose LLM text generation interface using ESQL. I'm thinking the docs could be clearer if you agree:
- for me "completion" suggests it only finishes incomplete text
- actually does arbitrary text generation tasks (qa, summarization, translation, etc.) based on the model you use
- we could frame the capabilities as "text generation" instead of "completion"
TBC I'm not expecting we rename the command, just how we describe it 😄
|
||
`column` | ||
: (Optional) The name of the output column that will contain the completion results. | ||
If not specified, the results will be stored in a column named `completion`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we don't have an example using the default behavior, might be nice, along with an annotation to make it clear
@afoucret just confirming, is COMPLETION landing in 9.1? Checking because we need to add the command to the Kibana inline docs manually, unlike functions/operators which works automatically |
No description provided.