Skip to content

Fix BulkInferenceExecutorTests timeout failures by reducing test load and increasing min thread pool size #130991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix BulkInferenceExecutorTests timeout failures by reducing test load and increasing min thread pool size #130991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d28d90b
Fix BulkInferenceExecutorTests timeout failures by reducing test load…
afoucret Jul 10, 2025
1d1c4a4
Unmute fixed test
afoucret Jul 11, 2025
11b13e6
Merge branch 'main' into fix-bulkinference-test-timeout
afoucret Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,9 +489,6 @@ tests:
- class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT
method: test {lookup-join.MvJoinKeyOnFrom SYNC}
issue: https://github.com/elastic/elasticsearch/issues/130296
- class: org.elasticsearch.xpack.esql.inference.bulk.BulkInferenceExecutorTests
method: testSuccessfulExecution
issue: https://github.com/elastic/elasticsearch/issues/130306
- class: org.elasticsearch.test.rest.yaml.RcsCcsCommonYamlTestSuiteIT
method: test {p0=msearch/20_typed_keys/Multisearch test with typed_keys parameter for sampler and significant terms}
issue: https://github.com/elastic/elasticsearch/issues/130472
Expand Down
8 changes: 4 additions & 4 deletions ...src/test/java/org/elasticsearch/xpack/esql/inference/bulk/BulkInferenceExecutorTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public void setThreadPool() {
new FixedExecutorBuilder(
Settings.EMPTY,
EsqlPlugin.ESQL_WORKER_THREAD_POOL_NAME,
between(1, 20),
between(4, 20),
1024,
"esql",
EsExecutors.TaskTrackingConfig.DEFAULT
Expand All @@ -61,7 +61,7 @@ public void shutdownThreadPool() {
}

public void testSuccessfulExecution() throws Exception {
List<InferenceAction.Request> requests = randomInferenceRequestList(between(1, 1000));
List<InferenceAction.Request> requests = randomInferenceRequestList(between(1, 100));
List<InferenceAction.Response> responses = randomInferenceResponseList(requests.size());

InferenceRunner inferenceRunner = mockInferenceRunner(invocation -> {
Expand Down Expand Up @@ -93,7 +93,7 @@ public void testSuccessfulExecutionOnEmptyRequest() throws Exception {
}

public void testInferenceRunnerAlwaysFails() throws Exception {
List<InferenceAction.Request> requests = randomInferenceRequestList(between(1, 1000));
List<InferenceAction.Request> requests = randomInferenceRequestList(between(1, 100));

InferenceRunner inferenceRunner = mock(invocation -> {
runWithRandomDelay(() -> {
Expand All @@ -115,7 +115,7 @@ public void testInferenceRunnerAlwaysFails() throws Exception {
}

public void testInferenceRunnerSometimesFails() throws Exception {
List<InferenceAction.Request> requests = randomInferenceRequestList(between(1, 1000));
List<InferenceAction.Request> requests = randomInferenceRequestList(between(1, 100));

InferenceRunner inferenceRunner = mockInferenceRunner(invocation -> {
ActionListener<InferenceAction.Response> listener = invocation.getArgument(1);
Expand Down