Rename prepareProcessPage to prepareProcessRawInputPage #130487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
approved these changes
Jul 11, 2025
|
No problem, thanks Nik! |
dnhatn
added
v9.1.1
v8.19.1
>refactoring
auto-backport
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jul 11, 2025
This PR proposes renaming `prepareProcessPage` to `prepareProcessRawInputPage` for two reasons: 1. The name `prepareProcessPage` can be confusing, as it suggests handling all types of input, but it only processes raw input, not intermediate input. 2. I plan to add `prepareProcessIntermediateInputPage`, which can enable optimizations for intermediate pages, such as leveraging ordinals from intermediate results.
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 11, 2025
…31110) This PR proposes renaming `prepareProcessPage` to `prepareProcessRawInputPage` for two reasons: 1. The name `prepareProcessPage` can be confusing, as it suggests handling all types of input, but it only processes raw input, not intermediate input. 2. I plan to add `prepareProcessIntermediateInputPage`, which can enable optimizations for intermediate pages, such as leveraging ordinals from intermediate results.
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jul 12, 2025
This PR proposes renaming `prepareProcessPage` to `prepareProcessRawInputPage` for two reasons: 1. The name `prepareProcessPage` can be confusing, as it suggests handling all types of input, but it only processes raw input, not intermediate input. 2. I plan to add `prepareProcessIntermediateInputPage`, which can enable optimizations for intermediate pages, such as leveraging ordinals from intermediate results. (cherry picked from commit 285866e)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes renaming
prepareProcessPagetoprepareProcessRawInputPagefor two reasons:The name
prepareProcessPagecan be confusing, as it suggests handling all types of input, but it only processes raw input, not intermediate input.I plan to add
prepareProcessIntermediateInputPage, which can enable optimizations for intermediate pages, such as leveraging ordinals from intermediate results.