-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Implemented ChatCompletion task for Google VertexAI with Gemini Models #128105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jonathan-buttner
merged 29 commits into
elastic:main
from
leo-hoet:google-vertexai-chatcompletion
May 29, 2025
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
00a6636
Implemented ChatCompletion task for Google VertexAI with Gemini Models
lhoet-google 9be2a44
changelog
lhoet-google c2387e8
System Instruction bugfix
lhoet-google 50770ea
Mapping role assistant -> model in vertex ai chat completion request …
lhoet-google 42cbbe2
GoogleVertexAI chat completion using SSE events. Removed JsonArrayEve…
lhoet-google fe8e336
Removed buffer from GoogleVertexAiUnifiedStreamingProcessor
lhoet-google 7c24f93
Casting inference inputs with `castoTo`
lhoet-google 2140d05
Registered GoogleVertexAiChatCompletionServiceSettings in InferenceNa…
lhoet-google 42dd376
Changed transport version to 8_19 for vertexai chatcompletion
lhoet-google 0863316
Fix to transport version. Moved ML_INFERENCE_VERTEXAI_CHATCOMPLETION_…
lhoet-google f080e96
VertexAI Chat completion request entity jsonStringToMap using `ensure…
lhoet-google 8f6648f
Fixed TransportVersions. Left vertexAi chat completion 8_19 and added…
lhoet-google 848dc7a
Refactor switch statements by if-else for older java compatibility. I…
lhoet-google 59862c6
Removed GoogleVertexAiChatCompletionResponseEntity and refactored cod…
lhoet-google 93a7ca7
Removed redundant test `testUnifiedCompletionInfer_WithGoogleVertexAi…
lhoet-google 7b99b1d
Returning whole body when fail to parse response from VertexAI
lhoet-google c05655f
Refactor use GenericRequestManager instead of GoogleVertexAiCompletio…
lhoet-google acc864f
Refactored to constructorArg for mandatory args in GoogleVertexAiUnif…
lhoet-google c371073
Changed transport version in GoogleVertexAiChatCompletionServiceSettings
lhoet-google efb90ba
Bugfix in tool calling with role tool
lhoet-google bb68715
Merge branch 'main' into google-vertexai-chatcompletion
lhoet-google 1ead8c5
GoogleVertexAiModel added documentation info on rateLimitGroupingHash
leo-hoet ad9f0e1
Merge branch 'main' into google-vertexai-chatcompletion
leo-hoet f4057f3
Merge branch 'main' into google-vertexai-chatcompletion
jonathan-buttner 38b9ca4
[CI] Auto commit changes from spotless
2e8dbee
Fix: using Locale.ROOT when calling toLowerCase
leo-hoet ddd19c5
Fix: Renamed test class to match convention & modified use of forbidd…
leo-hoet 88a2780
Fix: Failing test in InferenceServicesIT
leo-hoet b841e4e
Merge branch 'main' into google-vertexai-chatcompletion
leo-hoet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
pr: 128105 | ||
summary: "Adding Google VertexAI chat completion integration" | ||
area: Inference | ||
type: enhancement | ||
issues: [ ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify, it's not based on the service account key information too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a link to the docs that indicates this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Will do. https://ai.google.dev/gemini-api/docs/rate-limits
Also on the VertexAI quotas https://cloud.google.com/vertex-ai/docs/quotas#request_quotas
Some resources may not be affected by the region, but I choose to be conservative and go with a safe default