Query refactoring: SpanWithinQueryBuilder and Parser #12396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case INT_FIELD_NAME: littleValue = randomInt(); break; | ||
| case DOUBLE_FIELD_NAME: littleValue = randomDouble(); break; | ||
| case STRING_FIELD_NAME: littleValue = randomAsciiOfLengthBetween(1, 10); break; | ||
| default : littleValue = randomAsciiOfLengthBetween(1, 10); |
There was a problem hiding this comment.
we can reuse the method from some other PR that I saw today right?
There was a problem hiding this comment.
Yes, this will be shorter with the utility method I'm just preparing for #12342.
|
left a very minor comment, LGTM otherwise |
Moving the query building functionality from the parser to the builders new toQuery() method analogous to other recent query refactorings. Relates to elastic#10217
cbuescher
force-pushed
the
feature/query-refactoring-spanwithin
branch
from
c2ca645 to
fc1b5a9
Compare
cbuescher
added a commit
that referenced
this pull request
Jul 22, 2015
…anwithin Query refactoring: SpanWithinQueryBuilder and Parser
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…ring-spanwithin Query refactoring: SpanWithinQueryBuilder and Parser
|
This change is breaking for the java api as it removed setters for mandatory big/little inner span queries. Both arguments have to be supplied at construction time instead and have to be non-null. |
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the query building functionality from the parser to the builders
new toQuery() method analogous to other recent query refactorings.
Relates to #10217