Skip to content

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Jan 7, 2025

In contrast to other transport version checks, this needs to read data created by pre-8.8 nodes as part of a full cluster restart test. This means we need to keep the Version checks here until 10.0.

Relates #116941
Fixes #116989, fixes #116990

@thecoop thecoop added >test Issues or PRs that are addressing/adding tests :Core/Infra/Transport API Transport client API :Search Foundations/Search Catch all for Search Foundations labels Jan 7, 2025
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v9.0.0 labels Jan 7, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@thecoop thecoop changed the title Reinstate old TransportVersion BwC condition Reinstate node Version BwC check Jan 7, 2025
@thecoop thecoop requested a review from a team January 7, 2025 15:41
@thecoop thecoop requested a review from rjernst January 7, 2025 16:44
Copy link
Contributor

@drempapis drempapis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thecoop thecoop added the test-full-bwc Trigger full BWC version matrix tests label Jan 10, 2025
@thecoop thecoop merged commit da42d77 into elastic:main Jan 10, 2025
16 checks passed
@thecoop thecoop deleted the reinstate-querybuilder-bwc branch January 10, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Transport API Transport client API :Search Foundations/Search Catch all for Search Foundations Team:Core/Infra Meta label for core/infra team Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test Issues or PRs that are addressing/adding tests test-full-bwc Trigger full BWC version matrix tests v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] QueryBuilderBWCIT testQueryBuilderBWC {cluster=UPGRADED} failing [CI] QueryBuilderBWCIT testQueryBuilderBWC {p0=UPGRADED} failing
4 participants