Skip to content

fix/QueryBuilderBWCIT_muted_test #117831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

drempapis
Copy link
Contributor

@drempapis drempapis commented Dec 2, 2024

Work on test failures. Closes 116989 and 116990

@drempapis
Copy link
Contributor Author

In this pr #116941, the boolean bwc_tests_enabled in elasticsearch/build.gradle did not flip value before merging, provoking some compatibility failures, which the elastic search machine automatically reported. There is nothing to do here; just unmute the two tests.

@drempapis drempapis self-assigned this Dec 3, 2024
@drempapis drempapis added >bug Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch :Search Foundations/Search Catch all for Search Foundations labels Dec 3, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @drempapis, I've created a changelog YAML for you.

@drempapis drempapis marked this pull request as ready for review December 3, 2024 13:03
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@drempapis drempapis added auto-backport Automatically create backport pull requests when merged v8.18.0 labels Dec 4, 2024
@drempapis drempapis merged commit 02f3bc0 into elastic:main Dec 4, 2024
16 checks passed
@drempapis drempapis deleted the fix/QueryBuilderBWCIT_muted_test branch December 4, 2024 08:47
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 117831

@javanna
Copy link
Member

javanna commented Dec 4, 2024

Thanks for fixing @drempapis !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >bug :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants