Remove support for deprecated force_source highlighting parameter #116943
Conversation
force_source is being parsed as a no-op since 8.8. This commit removes support for it at REST, meaning a search request that provides it gets now an error back.
javanna
added
>breaking
:Search Relevance/Highlighting
|
Documentation preview: |
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
|
Hi @javanna, I've created a changelog YAML for you. Note that since this PR is labelled |
javanna
changed the title
| @@ -193,9 +189,6 @@ public final void writeTo(StreamOutput out) throws IOException { | |||
| } | |||
| out.writeOptionalWriteable(order); | |||
| out.writeOptionalBoolean(highlightFilter); | |||
| if (out.getTransportVersion().before(TransportVersions.V_8_8_0)) { | |||
| out.writeOptionalBoolean(false); | |||
| } | |||
There was a problem hiding this comment.
I have not added a new transport version associated with this change. My assumption is that it is not needed given that 9.0 will never communicate with versions previous than 8.last, hence the conditionals under which the flag was read or written are always going to render false.
|
Thanks for the speedy review @mayya-sharipova ! |
…astic#116943) force_source is being parsed as a no-op since 8.8. This commit removes support for it at REST, meaning a search request that provides it gets now an error back.
…astic#116943) force_source is being parsed as a no-op since 8.8. This commit removes support for it at REST, meaning a search request that provides it gets now an error back.
|
@javanna is this PR relevant to the serverless changelog? [FYI this question is based on 9.0 breaking changes] |
|
@leemthompo yes |
force_source is being parsed as a no-op since 8.8. This commit removes support for it at REST, meaning a search request that provides it gets now an error back.