Query refactoring: AndQueryBuilder and Parser #11628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public Query toQuery(QueryParseContext parseContext) throws QueryParsingException, IOException { | ||
| if (filters.isEmpty()) { | ||
| // no filters provided, this should be ignored upstream | ||
| return null; |
There was a problem hiding this comment.
same as comments in the previous PR, should we be ever returning null here? I tend to think we shouldn't.
There was a problem hiding this comment.
Same as in #11629, although unfortunate, this seems necessary at the moment.
|
left two minor comments, LGTM besides those |
cbuescher
force-pushed
the
feature/query-refactoring-and
branch
from
47ed7dc to
146587f
Compare
Moving the query building functionality from the parser to the builders new toQuery() method analogous to other recent query refactorings. Relates to elastic#10217 Closes elastic#11628
cbuescher
force-pushed
the
feature/query-refactoring-and
branch
from
146587f to
5a16ddc
Compare
|
Renamed the test case, keeping the |
|
LGTM |
cbuescher
added a commit
that referenced
this pull request
Jun 16, 2015
Query refactoring: AndQueryBuilder and Parser
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Moving the query building functionality from the parser to the builders new toQuery() method analogous to other recent query refactorings. Relates to elastic#10217 Closes elastic#11628
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…ring-and Query refactoring: AndQueryBuilder and Parser
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the query building functionality from the parser to the builders
new toQuery() method analogous to other recent query refactorings.
PR goes agains query-refactoring feature branch.