Support enrich remote mode #104993
Merged
Support enrich remote mode #104993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dnhatn, I've created a changelog YAML for you. |
dnhatn
commented
Feb 1, 2024
| * Ensure that no remote enrich is allowed after a reduction or an enrich with coordinator mode. | ||
| * <p> | ||
| * TODO: | ||
| * For Limit and TopN, we can insert the same node after the remote enrich (also needs to move projections around) |
There was a problem hiding this comment.
I will work on a follow-up for this.
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
costin
approved these changes
Feb 2, 2024
|
|
||
| public class EnrichHelper { | ||
|
|
||
| static String randomEnrichCommand(EnrichPolicy policy, String name, Enrich.Mode mode) { |
There was a problem hiding this comment.
This is better suited for org.elasticsearch.xpack.esql.EsqlTestUtils.
There was a problem hiding this comment.
++ I've moved it to 6027453
|
Thanks, Costin! |
|
Please see #105095 for the follow-up work related to this PR. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports enrich in remote mode. Enrich with remote mode can't be after another enrich with the coordinator mode, an aggregation, or a limit. While we can't address the first two limitations, we should remove the constraint with LIMIT. Otherwise, users are forced to write queries that may not perform well. For instance,
does not work. In such cases, users must rewrite it as
which is equivalent to bringing all data to the coordinating cluster.
We might consider implementing the actual remote enrich on the coordinating cluster (like remote field extracting), however, this requires retaining the originating cluster and restructing pages for routing, which might be complicated.