-
Notifications
You must be signed in to change notification settings - Fork 103
Fixing nodes info response #4636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b37952d
to
902b212
Compare
Following you can find the validation changes for the API you have modified.
You can validate this API yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In NodesInfo
:
- It looks like
remote_cluster_server
is missing? See NodesInfoResponse.java and RemoteClusterServerInfo.java. network
was removed in 2.0: elastic/elasticsearch#12054
Co-authored-by: Quentin Pradet <[email protected]>
…ing-nodes-info-resp
added and removed, thank you! it's likely that fields like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
* fix node info res * Update specification/nodes/info/types.ts Co-authored-by: Quentin Pradet <[email protected]> * address review --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 36e78a1)
* fix node info res * Update specification/nodes/info/types.ts Co-authored-by: Quentin Pradet <[email protected]> * address review --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 36e78a1)
* fix node info res * Update specification/nodes/info/types.ts Co-authored-by: Quentin Pradet <[email protected]> * address review --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 36e78a1)
* fix node info res * Update specification/nodes/info/types.ts Co-authored-by: Quentin Pradet <[email protected]> * address review --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 36e78a1)
* fix node info res * Update specification/nodes/info/types.ts * address review --------- (cherry picked from commit 36e78a1) Co-authored-by: Laura Trotta <[email protected]> Co-authored-by: Quentin Pradet <[email protected]>
* fix node info res * Update specification/nodes/info/types.ts * address review --------- (cherry picked from commit 36e78a1) Co-authored-by: Laura Trotta <[email protected]> Co-authored-by: Quentin Pradet <[email protected]>
* fix node info res * Update specification/nodes/info/types.ts * address review --------- (cherry picked from commit 36e78a1) Co-authored-by: Laura Trotta <[email protected]> Co-authored-by: Quentin Pradet <[email protected]>
* fix node info res * Update specification/nodes/info/types.ts * address review --------- (cherry picked from commit 36e78a1) Co-authored-by: Laura Trotta <[email protected]> Co-authored-by: Quentin Pradet <[email protected]>
From 1/112 validated responses to 112/112. Details:
NodeInfo
-> server codetransport.ignore_deserialization_errors
is said to be only used in unit tests, so I'm setting it as private -> server codeNodeJvmInfo
,bundled_jdk
is not actually there, there's onlyusing_bundled_jdk
-> server code