Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetAliasesResponse is a special case because it can return both an exception and the actual response, in case 2 aliases, 1 present and 1 missing, are added to GetAliasesRequest:
The error deserializer doesn't recognize
example-index
(or any other custom field), and so a TransportException is thrown. This PR adds a default case to the error response deserializer so that any additional field is tentatively deserialized into themetadata
map ofErrorCause
.So the json above would still the client throw an ElasticsearchException, since there's a 404 error, and the rest of the information would be found in
metadata
like so:Fixes #1033, fixes #900