-
Notifications
You must be signed in to change notification settings - Fork 16
Ensure compatibility with httpx v0.28.0+ #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 CLA has been signed |
SSL errors are thrown slightly different in httpx v0.28.0+ - Ensure these are caught and re-raised as TlsErrors.
11e0243
to
f220877
Compare
pquentin
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM. This is great.
I relaxed the httpcore pin and linked to the httpx issue in the source code. Sorry for the delay.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 12, 2025
Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 8b66f40)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 12, 2025
Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 8b66f40)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 12, 2025
Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 8b66f40)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 12, 2025
Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 8b66f40)
pquentin
pushed a commit
that referenced
this pull request
Mar 13, 2025
Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 8b66f40) Co-authored-by: Carl Smedstad <[email protected]>
pquentin
pushed a commit
that referenced
this pull request
Mar 13, 2025
Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 8b66f40) Co-authored-by: Carl Smedstad <[email protected]>
pquentin
pushed a commit
that referenced
this pull request
Mar 13, 2025
Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 8b66f40) Co-authored-by: Carl Smedstad <[email protected]>
pquentin
pushed a commit
that referenced
this pull request
Mar 13, 2025
Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 8b66f40) Co-authored-by: Carl Smedstad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, Arch Linux maintainer here 👋
SSL errors are thrown slightly different in httpx v0.28.0+ - Ensure these are caught and re-raised as TlsErrors.